lkml.org 
[lkml]   [2012]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] pstore/ram: Make ECC size configurable
On Mon, Jun 18, 2012 at 07:15:55PM -0700, Anton Vorontsov wrote:
> @@ -478,7 +478,7 @@ static void ramoops_register_dummy(void)
> dummy_data->record_size = record_size;
> dummy_data->console_size = ramoops_console_size;
> dummy_data->dump_oops = dump_oops;
> - dummy_data->ecc = ramoops_ecc;
> + dummy_data->ecc_size = ramoops_ecc == 1 ? 16 : ramoops_ecc;
>

I know it's in the change log, but there should probably be a
comment here as well that 1 and 16 are magic backwards compatability
numbers.

> dummy = platform_device_register_data(NULL, "ramoops", -1,
> dummy_data, sizeof(struct ramoops_platform_data));

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-06-19 10:01    [W:0.133 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site