Messages in this thread | | | Date | Tue, 19 Jun 2012 16:27:47 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH -mm 4/7] mm: make page colouring code generic |
| |
On Mon, 18 Jun 2012 18:05:23 -0400 Rik van Riel <riel@redhat.com> wrote:
> From: Rik van Riel <riel@surriel.com> > > Fix the x86-64 page colouring code to take pgoff into account.
Could we please have a full description of what's wrong with the current code?
> Use the x86 and MIPS page colouring code as the basis for a generic > page colouring function. > > Teach the generic arch_get_unmapped_area(_topdown) code to call the > page colouring code. > > Make sure that ALIGN_DOWN always aligns down, and ends up at the > right page colour.
Some performance tests on the result would be interesting. iirc, we've often had trouble demonstrating much or any benefit from coloring.
| |