Messages in this thread | | | Date | Tue, 19 Jun 2012 09:30:50 -0500 | From | Seth Jennings <> | Subject | Re: [PATCH 03/10] zcache: fix a compile warning |
| |
On 06/19/2012 03:33 AM, Xiao Guangrong wrote:
> fix: > > drivers/staging/zcache/zcache-main.c: In function ‘zcache_comp_op’: > drivers/staging/zcache/zcache-main.c:112:2: warning: ‘ret’ may be used uninitial > > Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> > --- > drivers/staging/zcache/zcache-main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c > index 32fe0ba..74a3ac8 100644 > --- a/drivers/staging/zcache/zcache-main.c > +++ b/drivers/staging/zcache/zcache-main.c > @@ -93,7 +93,7 @@ static inline int zcache_comp_op(enum comp_op op, > u8 *dst, unsigned int *dlen) > { > struct crypto_comp *tfm; > - int ret; > + int ret = -1; > > BUG_ON(!zcache_comp_pcpu_tfms); > tfm = *per_cpu_ptr(zcache_comp_pcpu_tfms, get_cpu());
What about adding a default case in the switch like this?
default: ret = -EINVAL;
That way we don't assign ret twice.
-- Seth
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |