lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ 04/69] drm/i915: fix up ivb plane 3 pageflips
    On 06/18/2012 06:55 PM, Herton Ronaldo Krzesinski wrote:
    >> + default:
    >> + WARN_ONCE(1, "unknown plane in flip command\n");
    >> + ret = -ENODEV;
    >> + goto err;
    >
    > Shouldn't this have been "goto err_unpin;"?
    >
    > It's not a problem in the backport for 3.2, same code is in the original
    > patch, just noticed it seems a problem while looking at it; but by what
    > changelog says the default case is said to not trigger in "practice"
    > (catch programming error), so I think it doesn't pose a real issue in
    > practice.

    You are right, it should be err_unpin. I sent a patch rectifying this.

    In practice, this should not happen, but still, better be safe than
    sorry. Thanks for catching that!

    Eugeni


    \
     
     \ /
      Last update: 2012-06-19 01:01    [W:2.713 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site