Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH]: In kernel hibernation, suspend to both | Date | Mon, 18 Jun 2012 22:29:31 +0200 |
| |
On Monday, June 18, 2012, Borislav Petkov wrote: > On Mon, Jun 18, 2012 at 10:33:06AM +1000, Bojan Smojver wrote: > > On Sun, 2012-06-17 at 22:21 +0200, Rafael J. Wysocki wrote: > > > Yeah, that will do. > > > > Something like this maybe. I didn't really test this, so Borislav, > > please let me know whether this is something that may works for you. > > Yeah, this could probably work but it changes the progress indicator > unconditionally. > > I don't know what the general consensus is about the progress indicator > but if you want to keep the old behavior too, you probably need to carve > out the printk functionality from save_image() and pass flags to the new > function which printks different output depending on how it is. > > If we don't want the current output with how many pages it needs to use > on swap, then we can do the dots. > > Frankly, I don't have a preference.
I'm not sure if the current behavior is worth preserving. It's a bit hackish and doesn't work with dmesg buffer, as you have noticed.
So, I think printing a status line every 10% would be fine.
Thanks, Rafael
| |