Messages in this thread | | | Date | Mon, 18 Jun 2012 20:36:48 +0200 | Subject | Re: [PATCH 04/10] fblog: implement fblog_redraw() | From | David Herrmann <> |
| |
Hi Alan
On Sun, Jun 17, 2012 at 12:35 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Sun, 17 Jun 2012 00:04:20 +0200 > David Herrmann <dh.herrmann@googlemail.com> wrote: > >> This mostly copies the functionality from drivers/video/console/bitblit.c >> so we can draw the console content on all available framebuffers. >> >> All speed optimizations have been removed for simplicity. The original >> code depends heavily on CONFIG_VT so we cannot share the codebase here. > > No. That means we've got two sets of code to maintain not one. Fix the > dependancy. > > Pull the relevant subset of struct vc_data into another struct > Make struct vc_data be > > struct vc_data { > struct vc_whatever > rest > }
It's a bit more complex as we cannot call scr_read() either. Hence, I need to assemble the array of printed characters before calling the redraw functions. But that should be feasible, too. I just need to figure out how to avoid heavy allocations during redraw to avoid slowdowns.
If there are no objections I will send these patches as a separate patchset as we can apply it without fblog.
> Alan
Thanks for reviewing David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |