lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: select NEW_LEDS for driver of Lenovo ThinkPad USB Keyboard with TrackPoint
On 06/17/2012 03:52 AM, Bryan Wu wrote:

> commit 'HID: Driver for Lenovo Keyboard with Trackpoint'
> (c1dcad2d32d0252e8a3023d20311b52a187ecda3) introduced a compiling error due to
> unmetting dependency of CONFIG_LEDS_CLASS.
>
> on i386:
>
> ERROR: "led_brightness_set" [drivers/leds/led-class.ko] undefined!
> ERROR: "leds_list" [drivers/leds/led-class.ko] undefined!
> ERROR: "leds_list_lock" [drivers/leds/led-class.ko] undefined!
>
> and possibly related:
>
> warning: (ADB_PMU_LED && IWLWIFI && IWLEGACY && ATH5K && ATH9K && ATH9K_HTC && CARL9170_LEDS && TABLET_USB_WACOM && INPUT_WISTRON_BTNS && SENSORS_APPLESMC && IR_WINBOND_CIR && BACKLIGHT_ADP8860 && BACKLIGHT_ADP8870 && HID_LENOVO_TPKBD && ACER_WMI && ASUS_LAPTOP && DELL_LAPTOP && HP_ACCEL && THINKPAD_ACPI && EEEPC_LAPTOP && ASUS_WMI && ACPI_TOSHIBA && SAMSUNG_LAPTOP) selects LEDS_CLASS which has unmet direct dependencies (NEW_LEDS)
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>


Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.


> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index bb4fd6b..cea0951 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -271,6 +271,7 @@ config HID_LCPOWER
> config HID_LENOVO_TPKBD
> tristate "Lenovo ThinkPad USB Keyboard with TrackPoint"
> depends on USB_HID
> + select NEW_LEDS
> select LEDS_CLASS
> ---help---
> Support for the Lenovo ThinkPad USB Keyboard with TrackPoint.



--
~Randy


\
 
 \ /
  Last update: 2012-06-18 20:01    [W:0.024 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site