Messages in this thread | | | Date | Mon, 18 Jun 2012 08:04:46 +0200 | Subject | Re: [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free() | From | Linus Walleij <> |
| |
On Sun, Jun 17, 2012 at 5:17 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> ,--[ build failure ] > | ... > | .../pinctrl-mxs.c: In function 'mxs_dt_node_to_map': > | .../pinctrl-mxs.c:140:3: error: implicit declaration of function 'free' > | [-Werror=implicit-function-declaration] > | .../pinctrl-mxs.c:140:3: warning: incompatible implicit declaration of > | built-in function 'free' [enabled by default] > | ... > `-- > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > Cc: Linus Walleij <linus.walleij@linaro.org>
Fabio Estevam already sent a patch to fix this, which is merged, thanks anyway!
But:
> free_group: > - if (!purecfg) > - free(group); > + kfree(group);
Why did you delete the if (!purecfg) clause?
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |