Messages in this thread | | | Date | Mon, 18 Jun 2012 08:35:07 -0600 | From | David Ahern <> | Subject | Re: [RFC PATCH 0/2] libtraceevent/perf: Add support for trace-cmd plugins |
| |
On 6/18/12 8:21 AM, Steven Rostedt wrote: > > Anyway, I think it is important to get this into either libtraceevent or > another library, but I agree with Namhyung that it should not go in, in > its current form.
Great. No resistance to bringing this in.
> Either we add the 'pevent_' names to it, and we need to change things a > bit.
Sure, namespace cleanup is trivial.
> I want to redesign the plugin interface. Well, I do not need to be the > one to redesign it, but it needs to be updated by someone. > > Plugins need an interface that they can take parameters, or be modified > at run time. An option passed to perf or trace-cmd could modify how the > plugin works. Or during viewing of the output, parameters can be passed > to tell plugins to do things differently. > > Basically, we need to discuss the interface between plugins and the > libtraceevent library. Once we get a good idea of what is needed, then > we can start reusing the code from trace-cmd to make a much better > interface for users.
Ok. I'll poke around with this over the summer as I get spare time.
David
| |