lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] usb: gadget: mass_storage: require backing file for non-removable LUNs
On Mon, 18 Jun 2012, Michal Nazarewicz wrote:

> From: Michal Nazarewicz <mina86@mina86.com>
>
> The fsg_file_store() function does not check whether a LUN is removable or not
> allowing one to specify an empty file name for a non-removable LUN. This
> commit adds explicit check of whether a file name is provided for
> non-removable LUNs.

Looks okay. Note that in file_storage.c, the "file" attribute isn't
writable if the LUN isn't removable, and the "ro" attribute isn't
writable if the LUN is a cdrom. Maybe you would prefer to do things
that way instead.

Alan Stern



\
 
 \ /
  Last update: 2012-06-18 17:01    [W:0.040 / U:23.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site