lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][GIT PULL][v3.5] ftrace: Make all inline tags also include notrace

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 2012-06-18 at 10:56 +0200, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > ftrace: Make all inline tags also include notrace
> > >
> > > Commit 5963e317b1 ftrace/x86: Do not change stacks in DEBUG when calling lockdep
> > > prevented lockdep calls from the int3 breakpoint handler from reseting the
> > > stack if a function that was called was in the process of being converted
> > > for tracing and had a breakpoint on it.
> >
> > That's now how we refer to commits ...
> >
> > > Commit 45959ee7 ftrace: Do not function trace inlined functions
> > > only touched the 'inline' tags when CONFIG_OPMITIZE_INLINING was enabled.
> >
> > neither this :-/
> >
> > We tend to write it like this:
> >
> > Commit 45959ee7aa64 ("ftrace: Do not function trace
> > inlined functions") only touched the 'inline' tags when
> > CONFIG_OPMITIZE_INLINING was enabled.
>
> This looks like something that should be added to SubmittingPatches.
>
> Want me to rebase with a new changelog?

Yeah, please do - the changelogs were rather hard to read as it
was not clear where a commit title ends and where the original
sentence continues.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-06-18 16:41    [W:0.556 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site