Messages in this thread | | | Subject | Re: [PATCH v2 1/5] tools lib traceevent: Replace malloc_or_die to plain calloc in alloc_event() | From | Steven Rostedt <> | Date | Mon, 18 Jun 2012 09:37:10 -0400 |
| |
On Mon, 2012-06-18 at 11:50 +0900, Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@lge.com> > > Because the only caller of the alloc_event() > (pevent_parse_event) checks return value properly > and all it does after allocation is initializing, > it can be changed to use plain calloc. > > Thanks to Steven for suggesting this simpler way. > > Cc: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> Link: http://lkml.kernel.org/n/tip-wagq5qbdy1mytvjkrjbqt095@git.kernel.org > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/lib/traceevent/event-parse.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index c471075e4974..4f667fdc5fae 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -619,12 +619,7 @@ void pevent_print_printk(struct pevent *pevent) > > static struct event_format *alloc_event(void) > { > - struct event_format *event; > - > - event = malloc_or_die(sizeof(*event)); > - memset(event, 0, sizeof(*event)); > - > - return event; > + return calloc(1, sizeof(struct event_format)); > } > > static void add_event(struct pevent *pevent, struct event_format *event)
| |