Messages in this thread | | | Date | Mon, 18 Jun 2012 21:19:32 +0800 | From | Wanpeng Li <> | Subject | Re: [PATCH] mm/memcg: add unlikely to mercg->move_charge_at_immigrate |
| |
On Mon, Jun 18, 2012 at 05:09:36PM +0400, Glauber Costa wrote: >On 06/18/2012 05:10 PM, Wanpeng Li wrote: >>From: Wanpeng Li <liwp@linux.vnet.ibm.com> >> >>move_charge_at_immigrate feature is disabled by default. Charges >>are moved only when you move mm->owner and it also add additional >>overhead. > >How big is this overhead? > >That's hardly a fast path. And if it happens to matter, it will be >just bigger when you enable it, and the compiler start giving the >wrong hints to the code.
Thank you for your quick response.
Oh, Maybe I should just write comments "move_charge_at_immigrate feature is disabled by default. So add "unlikely", in order to compiler can optimize."
Best Regards, Wanpeng Li
>-- >To unsubscribe from this list: send the line "unsubscribe cgroups" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html
| |