Messages in this thread | | | From | Axel Lin <> | Date | Mon, 18 Jun 2012 13:19:12 +0800 | Subject | Re: [PATCH] regulator: tps62360: Simplify tps62360_set_voltage_time_sel implementation |
| |
2012/6/18 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Fri, Jun 08, 2012 at 02:35:32PM +0800, Axel Lin wrote: >> For linear mappings, we can use below equation to get the voltage difference >> between new_selector and old_selector: > > Applied, thanks. There's a new framework feature that Yadwinder Singh > has contributed which should allow this to be moved to the regulator > desc.
In this case, tps->change_uv_per_us is is calculated by : tps->change_uv_per_us = DIV_ROUND_UP(32000, BIT(ramp_ctrl));
Which means tps->change_uv_per_us may be not alignment to mV.
This make me think if we should change the unit of ramp_delay to uV/uS rather than mV/uS. So we can avoid truncate issue.
Regards, Axel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |