lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power_supply: pda_power: Complain if regulator operations fail
On Tue, Jun 12, 2012 at 09:46:26AM +0800, Mark Brown wrote:
> Rather than silently ignoring errors from the regulator enable and disable
> add a WARN_ON() - it's probably pretty important if we're not getting
> power, though it should be vanishingly unlikely in production.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---

Applied, thanks!

> drivers/power/pda_power.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
> index 214468f..ed54a35 100644
> --- a/drivers/power/pda_power.c
> +++ b/drivers/power/pda_power.c
> @@ -134,13 +134,13 @@ static void update_charger(void)
> regulator_set_current_limit(ac_draw, max_uA, max_uA);
> if (!regulator_enabled) {
> dev_dbg(dev, "charger on (AC)\n");
> - regulator_enable(ac_draw);
> + WARN_ON(regulator_enable(ac_draw));
> regulator_enabled = 1;
> }
> } else {
> if (regulator_enabled) {
> dev_dbg(dev, "charger off\n");
> - regulator_disable(ac_draw);
> + WARN_ON(regulator_disable(ac_draw));
> regulator_enabled = 0;
> }
> }
> --
> 1.7.10

--
Anton Vorontsov
Email: cbouatmailru@gmail.com


\
 
 \ /
  Last update: 2012-06-18 07:21    [W:0.044 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site