lkml.org 
[lkml]   [2012]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.5] c/r: prctl: less paranoid prctl_set_mm_exe_file()
On Sat, Jun 16, 2012 at 07:44:24PM +0400, Cyrill Gorcunov wrote:
> On Sat, Jun 16, 2012 at 07:38:29PM +0400, Konstantin Khlebnikov wrote:
> > >Yeah, you've changed !path_equal to path_equal. And yes, getting rid of
> > >num_exe_file_vmas is good idea. Btw, Konstantin, why do we need to
> > >call for path_equal? Maybe we can simply test for mm->exe_file == NULL,
> > >and refuse to change anything if it's not nil value? This will simplify
> > >the code.
> >
> > After removing VM_EXECUTABLE and mm->num_exe_file_vmas mm->exe_file
> > will never becomes NULL automatically. Patch for this not commited yet,
> > but I hope it will be in 3.6.
>
> OK, lets stick with current patch then.

To clarify

Tested-by: Cyrill Gorcunov <gorcunov@openvz.org>

Andrew, could you please pick up this bugfix. It's critical for us.

P.S. Together with patch https://lkml.org/lkml/2012/6/15/220 it'll be
last changes to prctl in a sake of c/r I think. Would be cool to have
both bugfixes in 3.5.

Cyrill


\
 
 \ /
  Last update: 2012-06-18 12:01    [W:0.033 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site