Messages in this thread | | | Date | Mon, 18 Jun 2012 04:20:54 -0400 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v5] slab/mempolicy: always use local policy from interrupt context |
| |
(6/9/12 5:40 AM), David Mackey wrote: > From: Andi Kleen<ak@linux.intel.com> > > From: Andi Kleen<ak@linux.intel.com> > > slab_node() could access current->mempolicy from interrupt context. > However there's a race condition during exit where the mempolicy > is first freed and then the pointer zeroed. > > Using this from interrupts seems bogus anyways. The interrupt > will interrupt a random process and therefore get a random > mempolicy. Many times, this will be idle's, which noone can change. > > Just disable this here and always use local for slab > from interrupts. I also cleaned up the callers of slab_node a bit > which always passed the same argument. > > I believe the original mempolicy code did that in fact, > so it's likely a regression. > > v2: send version with correct logic > v3: simplify. fix typo. > Reported-by: Arun Sharma<asharma@fb.com> > Cc: penberg@kernel.org > Cc: cl@linux.com > Signed-off-by: Andi Kleen<ak@linux.intel.com> > [tdmackey@twitter.com: Rework control flow based on feedback from > cl@linux.com, fix logic, and cleanup current task_struct reference] > Signed-off-by: David Mackey<tdmackey@twitter.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |