Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH 04/12] irqdomain: Eliminate dedicated radix lookup functions | Date | Sun, 17 Jun 2012 15:58:39 -0600 |
| |
On Sat, 16 Jun 2012 00:12:45 -0600, Grant Likely <grant.likely@secretlab.ca> wrote: > On Fri, Jun 15, 2012 at 11:56 PM, Benjamin Herrenschmidt > <benh@kernel.crashing.org> wrote: > > On Fri, 2012-06-15 at 23:01 -0600, Grant Likely wrote: > >> @@ -329,9 +329,6 @@ static int xics_host_map(struct irq_domain *h, unsigned int virq, > >> > >> Â Â Â pr_devel("xics: map virq %d, hwirq 0x%lx\n", virq, hw); > >> > >> - Â Â /* Insert the interrupt mapping into the radix tree for fast lookup */ > >> - Â Â irq_radix_revmap_insert(xics_host, virq, hw); > >> - > >> Â Â Â /* They aren't all level sensitive but we just don't really know */ > >> Â Â Â irq_set_status_flags(virq, IRQ_LEVEL); > > > > This looks like it belongs in a different patch, possibly "[02/12] > > irqdomain: Always update revmap when setting up a virq" no ? [...] > >> @@ -415,7 +415,9 @@ int irq_domain_associate_many(struct irq_domain *domain, unsigned int irq_base, > >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â domain->revmap_data.linear.revmap[hwirq] = virq; > >> Â Â Â Â Â Â Â Â Â Â Â break; > >> Â Â Â Â Â Â Â case IRQ_DOMAIN_MAP_TREE: > >> - Â Â Â Â Â Â Â Â Â Â irq_radix_revmap_insert(domain, virq, hwirq); > >> + Â Â Â Â Â Â Â Â Â Â mutex_lock(&revmap_trees_mutex); > >> + Â Â Â Â Â Â Â Â Â Â radix_tree_insert(&domain->revmap_data.tree, hwirq, irq_data); > >> + Â Â Â Â Â Â Â Â Â Â mutex_unlock(&revmap_trees_mutex); > >> Â Â Â Â Â Â Â Â Â Â Â break; > >> Â Â Â Â Â Â Â } > > > > That too looks like it belongs in another patch. > > Okay, I'll take a look at those.
Both moved to patch 2.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |