Messages in this thread | | | From | Bryan Wu <> | Date | Fri, 15 Jun 2012 12:14:40 +0800 | Subject | Re: [PATCH v2] leds: use led_set_brightness in led_trigger_event |
| |
On Fri, Jun 15, 2012 at 2:33 AM, Fabio Baltieri <fabio.baltieri@gmail.com> wrote: > Fix led_trigger_event() to use led_set_brightness() instead of > __led_set_brightness(), so that any pending blink timer is stopped before > setting the new brightness value. Without this fix LED status may be > overridden by a pending timer. > > This allows a trigger to use a mix of led_trigger_event(), > led_trigger_blink() and led_trigger_blink_oneshot() without races. > > (applied over: leds: Rename led_brightness_set() to led_set_brightness()) > > Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com> > Cc: Shuah Khan <shuahkhan@gmail.com> > Cc: Bryan Wu <bryan.wu@canonical.com>
Thanks, applied to for-next branch on top of Shuah's renaming patch.
-Bryan
> --- > > Hi Shuah, > > thanks for the renaming, looks much more clear now, so that's my > led_trigger_event patch which applies on top of your latest patch - which > should still be needed if I didn't lost anything. > > Fabio > > drivers/leds/led-triggers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > index 57721f2..de1c59d 100644 > --- a/drivers/leds/led-triggers.c > +++ b/drivers/leds/led-triggers.c > @@ -224,7 +224,7 @@ void led_trigger_event(struct led_trigger *trig, > struct led_classdev *led_cdev; > > led_cdev = list_entry(entry, struct led_classdev, trig_list); > - __led_set_brightness(led_cdev, brightness); > + led_set_brightness(led_cdev, brightness); > } > read_unlock(&trig->leddev_list_lock); > } > -- > 1.7.11.rc1.9.gf623ca1.dirty >
-- Bryan Wu <bryan.wu@canonical.com> Kernel Developer +86.186-168-78255 Mobile Canonical Ltd. www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |