lkml.org 
[lkml]   [2012]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: linux-next: Tree for Jun 14 (staging/comedi)
On Friday, June 15, 2012 4:25 AM, Ian Abbott wrote:
> On 2012-06-14 22:38, Randy Dunlap wrote:
>> On 06/13/2012 11:29 PM, Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20120613:
>>
>>
>>
>> when CONFIG_PCMCIA is not enabled:
>>
>> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
>> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>
> This seems to be caused by this commit in the linux-next repository:
>
> 4829a9967dbe3a3ab192df0bfdde281960cc1319 is the first bad commit
> commit 4829a9967dbe3a3ab192df0bfdde281960cc1319
> Author: H Hartley Sweeten <hartleys@visionengravers.com>
> Date: Tue Jun 12 17:37:10 2012 -0700
>
> staging: comedi: Kconfig: cleanup depends on logic
>
> All of the config options for comedi depend on COMEDI being
> selected. Wrap everything in an 'if COMEDI/endif' block and
> remove all the individual 'depends on COMEDI' in the Kconfig.
>
> Also, remove the redundant && ISA/PCI/PCMCIA/USB for the if
> blocks with those driver types.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbott@mev.co.uk>
> Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>

OK. The problem appears to be in the depends for COMEDI_PCMCIA_DRIVERS.

menuconfig COMEDI_PCMCIA_DRIVERS
tristate "Comedi PCMCIA drivers"
depends on (PCMCIA || PCCARD)

Depending on PCCARD is redundant. It must be enabled in order to select
PCMCIA. Patch coming shortly.

Sorry about that.

Regards,
Hartley


\
 
 \ /
  Last update: 2012-06-15 19:01    [W:0.236 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site