Messages in this thread | | | Date | Fri, 15 Jun 2012 11:52:34 -0400 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] mm: clear pages_scanned only if draining a pcp adds pages to the buddy allocator again |
| |
(6/15/12 3:19 AM), Minchan Kim wrote: > On 06/15/2012 01:16 AM, kosaki.motohiro@gmail.com wrote: > >> From: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> >> >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two >> another miuse still exist. >> >> This patch fixes it. >> >> Cc: David Rientjes<rientjes@google.com> >> Cc: Mel Gorman<mel@csn.ul.ie> >> Cc: Johannes Weiner<hannes@cmpxchg.org> >> Cc: Minchan Kim<minchan.kim@gmail.com> >> Cc: Wu Fengguang<fengguang.wu@intel.com> >> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> >> Cc: Rik van Riel<riel@redhat.com> >> Cc: Andrew Morton<akpm@linux-foundation.org> >> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > > Reviewed-by: Minchan Kim<minchan@kernel.org> > > Just nitpick. > Personally, I want to fix it follwing as > It's more simple and reduce vulnerable error in future. > > If you mind, go ahead with your version. I am not against with it, either.
I don't like your version because free_pcppages_bulk() can be called from free_pages() hotpath. then, i wouldn't like to put a branch if we can avoid it.
| |