lkml.org 
[lkml]   [2012]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/14] mfd: Add IRQ domain support for the AB8500
On 14/06/12 19:32, Mark Brown wrote:
> On Mon, Jun 11, 2012 at 04:25:01PM +0100, Lee Jones wrote:
>
>> + if (np) {
>> + ab8500->domain = irq_domain_add_linear(
>> + np, num_irqs,&ab8500_irq_ops, ab8500);
>> + }
>> + else {
>> + ab8500->domain = irq_domain_add_legacy(
>> + NULL, num_irqs, ab8500->irq_base,
>> + 0,&ab8500_irq_ops, ab8500);
>> + }
>
> This is odd, why are you forcing non-DT systems to use a legacy mapping?
> The more usual approach is to use a legacy mapping if and only if a base
> for the legacy range has been provided, otherwise the system will
> needlessly fail to initialise the device...

Makes sense. I'll re-submit.

>> + if (!(ab8500->irq_base || np)) {
>> + dev_info(&pdev->dev, "couldn't find irq-base and not doing DT boot\n");
>
> ...like this. See regmap_irq for an example.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-06-15 16:01    [W:0.476 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site