Messages in this thread | | | From | Jim Cromie <> | Date | Thu, 14 Jun 2012 14:32:38 -0600 | Subject | Re: [PATCH] init: add comments to keep initcall-names in sync with initcall levels |
| |
On Thu, Jun 14, 2012 at 1:23 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > On Thu, 2012-06-14 at 12:51 -0600, Jim Cromie wrote:
>> * >> * This only exists for built-in code, not for modules. >> + * Keep main.c:initcall_level_names[] in sync. */ >> */
> This comment now ends with "*/" twice. Perhaps that's legal (I haven't > even bothered to check) but it is really too ugly.
Guilty as charged, revision forthcoming.
>> >> -/* Don't use these in modules, but some people do... */ >> +/* Don't use these in loadable modules, but some people do... */ > > What problem does this solve? >
kernel/params.c and other builtins are also modules - at least wrt how theyre reported by dynamic_debug:
kernel/params.c:121 [params]parse_one =_ "Unknown argument `%s'\012" kernel/params.c:117 [params]parse_one =_ "Unknown argument: calling %p\012" kernel/params.c:108 [params]parse_one =_ "They are equal! Calling %p\012" kernel/params.c:188 [params]parse_args =_ "Parsing ARGS: %s\012"
The advice to avoid those macros does not apply to builtin "modules"
| |