lkml.org 
[lkml]   [2012]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] x86, fpu: unify signal handling code paths for x86 and x86_64 kernels
Hi Suresh,

On Tue, Jun 12, 2012 at 05:03:34PM -0700, Suresh Siddha wrote:
> I can split the patch if needed. And I need to do little bit more
> validation (already tested on 64-bit IVB and 32-bit NHM) before
> removing the 'RFC' tag.
>
> I tried starting with the old version of Hans patch. But there were lot
> more changes in this area since then and also his patch had few
> user-visible compatibility issues.
>
> Appended is the version that I came up with. Please review.

Thank you for working on this.

I didn't see anything obviously wrong in a quick review of this code,
but this stuff is too complex for this to mean anything :)

I ran a quick test of your code. I found a signal frame corruption when
running a 32bit test program on a 64bit kernel. I didn't try to find out
why it failed, but I'll send you the test program in a private mail so
you can look at it yourself.


Hans


--
%SYSTEM-F-ANARCHISM, The operating system has been overthrown



\
 
 \ /
  Last update: 2012-06-14 17:21    [W:0.100 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site