Messages in this thread | | | Date | Thu, 14 Jun 2012 10:35:36 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning |
| |
Hi Seth,
On 06/14/2012 06:03 AM, Seth Jennings wrote:
> This patch fixes an uninitialized variable warning in > alloc_zspage(). It also fixes the secondary issue of > prev_page leaving scope on each loop iteration. The only > reason this ever worked was because prev_page was occupying > the same space on the stack on each iteration. > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Nice catch!
Acked-by: Minchan Kim <minchan@kernel.org>
Nitpick: I can't see the warning. My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.
Please, Cced linux-mm, too. Some guys in mm might have a interest in zsmalloc. :)
-- Kind regards, Minchan Kim
| |