lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/14] staging/xgifb: Remove assignments without effect
    Date
    This patch removes assignments to the fb_fix_screeninfo struct which are
    overwritten by the memset in XGIfb_get_fix() a few lines later.
    Since the name/id might be useful this was moved to XGIfb_get_fix().

    Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
    ---
    drivers/staging/xgifb/XGI_main_26.c | 7 ++-----
    1 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
    index 85dbf32..ff88f1d 100644
    --- a/drivers/staging/xgifb/XGI_main_26.c
    +++ b/drivers/staging/xgifb/XGI_main_26.c
    @@ -1348,6 +1348,8 @@ static int XGIfb_get_fix(struct fb_fix_screeninfo *fix, int con,
    DEBUGPRN("inside get_fix");
    memset(fix, 0, sizeof(struct fb_fix_screeninfo));

    + strncpy(fix->id, "XGI", sizeof(fix->id) - 1);
    +
    fix->smem_start = xgifb_info->video_base;

    fix->smem_len = xgifb_info->video_size;
    @@ -2230,11 +2232,6 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,

    }

    - strncpy(fb_info->fix.id, "XGI", sizeof(fb_info->fix.id) - 1);
    - fb_info->fix.type = FB_TYPE_PACKED_PIXELS;
    - fb_info->fix.xpanstep = 1;
    - fb_info->fix.ypanstep = 1;
    -
    fb_info->flags = FBINFO_FLAG_DEFAULT;
    fb_info->screen_base = xgifb_info->video_vbase;
    fb_info->fbops = &XGIfb_ops;
    --
    1.7.3.4


    \
     
     \ /
      Last update: 2012-06-14 01:01    [W:4.144 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site