Messages in this thread | | | Date | Wed, 13 Jun 2012 23:00:32 +0530 | Subject | Re: [PATCH] pinctrl: mxs: Use kfree to fix build error | From | "devendra.aaru" <> |
| |
Hi Fabio,
On Wed, Jun 13, 2012 at 10:36 PM, Fabio Estevam <fabio.estevam@freescale.com> wrote: > commit 0bf7481 (pinctrl: pinctrl-mxs: Take care of frees if the kzalloc fails) > introduced the following build error: > > drivers/pinctrl/pinctrl-mxs.c:140:3: error: implicit declaration of function 'free' > > Use kfree function instead. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > This applies against linux-next > drivers/pinctrl/pinctrl-mxs.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c > index afb50ee..4ba4636 100644 > --- a/drivers/pinctrl/pinctrl-mxs.c > +++ b/drivers/pinctrl/pinctrl-mxs.c > @@ -137,7 +137,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev, > > free_group: > if (!purecfg) > - free(group); > + kfree(group); > free: > kfree(new_map); > return ret; > -- > 1.7.1 > >
agh, i am very sorry that i didn't built this because it was not selectable in make allconfig. (mine is x86 intel corei3), anyway its wrong that i used a userspace free instead kfree.
Thanks for fixing this.
Acked-by: Devendra Naga <devendra.aaru@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |