Messages in this thread | | | Date | Wed, 13 Jun 2012 22:31:13 +0900 | Subject | Re: [PATCH 2/5] drivers/net/ethernet/dec/tulip: Use standard __set_bit_le() function | From | Akinobu Mita <> |
| |
2012/6/13 Takuya Yoshikawa <takuya.yoshikawa@gmail.com>: > On Wed, 13 Jun 2012 18:43:40 +0900 > Akinobu Mita <akinobu.mita@gmail.com> wrote: > >> Should this hash_table be converted from u16 hash_table[32] to >> DECLARE_BITMAP(hash_table, 16 * 32) to ensure that it is aligned >> on long-word boundary? > > I think hash_table is already long-word aligned because it is placed > right after a pointer.
I recommend converting to proper bitmap. Because such an implicit assumption is easily broken by someone touching this function.
| |