Messages in this thread | | | Date | Wed, 13 Jun 2012 15:20:53 +0200 | Subject | Re: [RFC 4/4] sched: cpu_power: enable ARCH_POWER | From | Vincent Guittot <> |
| |
On 13 June 2012 14:50, Peter Zijlstra <peterz@infradead.org> wrote: > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: >> Heteregeneous ARM platform uses arch_scale_freq_power function >> to reflect the relative capacity of each core > > I think I've pointed out before that this breaks x86.. you need a patch > killing at that stuff before this.
In v3.4, x86 hasn't got any specific declaration for arch_scale_freq_power so it would now use the weak arch_scale_freq_power which calls default_scale_freq_power. Isn't it enough ?
> >> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> >> --- >> kernel/sched/features.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/features.h b/kernel/sched/features.h >> index de00a48..d98ae90 100644 >> --- a/kernel/sched/features.h >> +++ b/kernel/sched/features.h >> @@ -42,7 +42,7 @@ SCHED_FEAT(CACHE_HOT_BUDDY, true) >> /* >> * Use arch dependent cpu power functions >> */ >> -SCHED_FEAT(ARCH_POWER, false) >> +SCHED_FEAT(ARCH_POWER, true) >> >> SCHED_FEAT(HRTICK, false) >> SCHED_FEAT(DOUBLE_TICK, false) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |