lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree
On Wed, 13 Jun 2012 16:03:23 +0800
Lin Ming <ming.m.lin@intel.com> wrote:

> On Mon, May 28, 2012 at 5:51 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >> +static int is_pci_ata(struct device *dev)
> >> +{
> >> +     struct pci_dev *pdev;
> >> +
> >> +     if (!is_pci_dev(dev))
> >> +             return 0;
> >> +
> >> +     pdev = to_pci_dev(dev);
> >> +
> >> +     if ((pdev->class >> 8) != PCI_CLASS_STORAGE_SATA &&
> >> +         (pdev->class >> 8) != PCI_CLASS_STORAGE_IDE)
> >> +             return 0;
> >
> > This needs a better name. It doesn't check if a device is PCI ATA or
> > anything of the sort, it checks if its probably a device in compatibility
> > mode. A lot of controllers will in fact report RAID class or similar in
> > native mode.
>
> How about compat_pci_ata?

Sounds reasonable. I'm not btw sure the test is entirely right, but I'm
not sure quite what you are trying to figure out from it and how ACPI
expects this mapping to work.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-06-13 13:41    [W:0.068 / U:2.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site