lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] include: Fix compile warning in include/linux/bitops.h
On Fri,  8 Jun 2012 23:15:30 -0400
Namjae Jeon <linkinjeon@gmail.com> wrote:

> The compile warning is caused by __const_hweight8 when using
> hweight_long with -Wsign-compare option.
> The reason is that the default return value of this macro is signed.
> So need type casting to remove warning.

um, what warning?

Please always quote the compiler messages when fixing build warnings or
errors.

> index fa2a50b..3ad0dae 100644
> --- a/include/asm-generic/bitops/const_hweight.h
> +++ b/include/asm-generic/bitops/const_hweight.h
> @@ -4,7 +4,7 @@
> /*
> * Compile time versions of __arch_hweightN()
> */
> -#define __const_hweight8(w) \
> +#define __const_hweight8(w) (unsigned long) \
> ( (!!((w) & (1ULL << 0))) + \
> (!!((w) & (1ULL << 1))) + \
> (!!((w) & (1ULL << 2))) + \



\
 
 \ /
  Last update: 2012-06-12 01:41    [W:0.063 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site