| Date | Fri, 1 Jun 2012 18:51:13 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors |
| |
> +/* Implement the following functions in your architecture, as appropriate. */ > + > +/** > + * __cpu_pre_starting() > + * > + * Implement whatever you need to do before the CPU_STARTING notifiers are > + * invoked. Note that the CPU_STARTING callbacks run *on* the cpu that is > + * coming up. So that cpu better be prepared! IOW, implement all the early > + * boot/init code for the cpu here. And do NOT enable interrupts. > + */ > +#ifndef __cpu_pre_starting > +void __weak __cpu_pre_starting(void *arg) {} > +#endif
__What __is __the __purpose __of __all __these __underscaores __used __as __function __prefix? __It __does __not __help __readability.
Does the nicely worded comment follow kerneldoc style? I think not as the parameter is not described.
Sam
|