Messages in this thread Patch in this message | | | From | Chris Ball <> | Subject | Re: [PATCH V2] MMC: core: cap MMC card timeouts at 2 seconds. | Date | Fri, 01 Jun 2012 10:48:14 -0400 |
| |
Hi,
On Fri, Jun 01 2012, Adrian Hunter wrote: > I just noticed that from linux 3.4, the SD write timeout is now 3 seconds > triggering the sdhci driver warning on every write on every SD card. > So change pr_warning to DGB in sdhci_calc_timeout(). Chris?
Oops, thanks for noticing:
Subject: mmc: sdhci: Use DBG() instead of pr_warning() on large timeout
3bdc9ba892d6 ("mmc: use really long write timeout to deal with crappy cards") in 3.4 increased the write timeout that the core sends to host drivers to 3 seconds. This makes sdhci's "requested timeout too large" warning trigger on every write; so, change this pr_warning() to a DBG().
Reported-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Chris Ball <cjb@laptop.org> --- drivers/mmc/host/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index e626732..f4b8b4d 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -680,8 +680,8 @@ static u8 sdhci_calc_timeout(struct sdhci_host *host, struct mmc_command *cmd) } if (count >= 0xF) { - pr_warning("%s: Too large timeout 0x%x requested for CMD%d!\n", - mmc_hostname(host->mmc), count, cmd->opcode); + DBG("%s: Too large timeout 0x%x requested for CMD%d!\n", + mmc_hostname(host->mmc), count, cmd->opcode); count = 0xE; } -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child
| |