Messages in this thread | | | Date | Thu, 10 May 2012 11:41:33 +0800 | From | Michael Wang <> | Subject | Re: [PATCH] sched: Make nr_uninterruptible count a signed value |
| |
On 05/09/2012 04:11 PM, Peter Zijlstra wrote:
> On Tue, 2012-05-08 at 15:46 -0700, Diwakar Tundlam wrote: >> Maybe it is an artifact of 32-bit machine displaying 64-bit print format. >> An (unsigned long)(-24) promoted to (signed long long) ends up as 4294967272. >> As seen in my output of sched_debug. > > Ah, quite possible. %Ld is indeed %lld and the value is long, not long > long. So the proper fix is to fudge that printk statement somehow.
Could we use SEQ_printf for nr_uninterruptible, just like we did on rq->load.weight?
Regards, Michael Wang
> >> Your machine is probably natively 64-bit. > > Yeah, I gave up on 32bit computing a while ago.. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |