Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 9 May 2012 18:18:11 -0700 | Subject | Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-length record buffer |
| |
On Wed, May 9, 2012 at 5:54 PM, Kay Sievers <kay@vrfy.org> wrote: > > How about this? It relaxes the need for KERN_CONT, but it limits > continuation lines to repeated calls of the same thread.
Fair enough, looks reasonable.
Except your case-statement sucks. Having a "case 'c':" that basically then immediately has an "if (it was not 'c')" is just disturbing. Just move the code that is common to all the cases outside the case statement entirely, and make the 'c' case not do anything at all, and remove that crazy extraneous if-statement.
Linus
| |