Messages in this thread | | | Subject | Re: [PATCH]: In kernel hibernation, suspend to both | From | Bojan Smojver <> | Date | Wed, 09 May 2012 20:49:39 +1000 |
| |
On Wed, 2012-05-09 at 13:40 +0530, Srivatsa S. Bhat wrote: > > + error = suspend_devices_and_enter(PM_SUSPEND_MEM); > > > I can imagine running into a host of problems here, since the suspend > sequence is not carried out fully, from the beginning. > > For example, this will skip sending out the PM_SUSPEND_PREPARE and the > PM_POST_SUSPEND notifiers. Worse, we actually send out the > PM_HIBERNATION_PREPARE > and PM_POST_HIBERNATION notifiers and then do a suspend instead, > underneath! > > (Similar cases for the rest of the notifiers sent during suspend vs > hibernation). > > Don't we need to handle such things properly, in order to make > suspend-to-both > work reliably?
Honest answer - I have absolutely no idea. I've seen the code of suspend-utils (i.e. user mode stuff) and it seems to me that it does exactly this. Could be wrong of course, just like many times before.
Rafael?
-- Bojan
| |