Messages in this thread | | | Subject | Re: [PATCH 4/5] x86: Allow nesting of the debug stack IDT setting | From | Steven Rostedt <> | Date | Thu, 31 May 2012 22:30:31 -0400 |
| |
On Thu, 2012-05-31 at 15:25 -0400, Steven Rostedt wrote: > On Thu, 2012-05-31 at 11:58 -0700, H. Peter Anvin wrote: > > > What you have here is a nesting counter, which is good, but I have > > some objections to the implementation. > > > > The name "debug_idt_zero" doesn't convey a counter in any way, shape > > or form; perhaps debug_stack_users or something like that. > > Well, it is 'debug_idt_SET_zero' which is what it is doing, regardless > of counter (see below). But perhaps we should change it to: > > debug_idt_get() > debug_idt_put()
Bah, silly me, I misunderstood you. You were talking about the counter itself, not the function names.
OK, will fix.
Thanks,
-- Steve
| |