Messages in this thread Patch in this message | | | Date | Thu, 31 May 2012 10:22:28 -0300 | Subject | Re: Lots of i915/drm spew on 3.4 | From | Paulo Zanoni <> |
| |
2012/5/31 Chris Wilson <chris@chris-wilson.co.uk>: > Before that commit we had no idea that we had run out of property slots. > I think the WARN is genuine, but maybe we should just bump the count set > it to WARN_ONCE and hope the conversion to lists arrives sooner rather > than latter. > -Chris >
Chris is right: this is not a regression. Before that patch, no one checked if property creation really worked. I chose not to use WARN_ONCE because we need to increase the variable once for each time you see the message. Assuming this message appears on your log less than 8 times, does this patch fix your problem?
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 73e4560..bac55c2 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -54,7 +54,7 @@ struct drm_mode_object { struct drm_object_properties *properties; };
-#define DRM_OBJECT_MAX_PROPERTY 16 +#define DRM_OBJECT_MAX_PROPERTY 24 struct drm_object_properties { int count; uint32_t ids[DRM_OBJECT_MAX_PROPERTY];
-- Paulo Zanoni
| |