lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] video/sis: Use SiS_DRAMType from init.h and annotate it __devinitconst
Date
Hi Florian,

> As far as I can see it should be possible to keep the array in
> sis_main.c and just delete it in the header files, shouldn't it? I'd
> prefer to do it this way.

Yes it is absolutely possible to leave it in sis_main.c and remove it from the
header files. I already thought about this when creating the patch, but
decided against it, as the 17*5 = 85 bytes are allocated on the stack, while
they nicely can be put in the .devinit.rodata section ;)

With the patch:
344072 sis_main.o
1200950 sisfb.o
1217491 sisfb.ko

vs without the patch and removing it only from the header:
344176 sis_main.o
1201056 sisfb.o
1217597 sisfb.ko -> ~100bytes more in the final module.

However I'm fine with this and will remove it from the header and squash this
together with the
"video/sis: Remove unused structs SiS_SDRDRAM_TYPE/SiS_DDRDRAM_TYPE"
I also sent to you.


Thanks,
Peterq


\
 
 \ /
  Last update: 2012-05-04 00:01    [W:0.082 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site