Messages in this thread | | | Date | Thu, 03 May 2012 14:49:43 -0600 | From | David Ahern <> | Subject | Re: [PATCH 09/13] perf target: Introduce perf_target_errno |
| |
On 5/3/12 2:42 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, May 03, 2012 at 02:34:20PM -0600, David Ahern escreveu: >> On 5/2/12 12:59 PM, Arnaldo Carvalho de Melo wrote: >>> Also it would be better to have it as PERF_ERRNO__PID_OVERRIDE_CPU, etc. >> >> I thought you wanted subsystem based errno's (PERF_TARGET__XXXXX) >> versus one big set (PERF_ERRNO__XXXXX). Did you change your mind? > > Oops, I didn't realize PID being the subsys, then yeah, that is ok. > > But that would make it PERF_ERR__TARGET_, as PERF_TARGET__ doesn't > straight away brings back "error enumeration", at least for me :) > > But this is getting overly long, ideas? > > PERF_ we need, its libperf's "namespace", then ERRNO looks needed too, > heck, make it long: > > PERF_ERRNO_TARGET__PID_OVERRIDE_CPU > > After all most of the time this will just be inside the function setting > the error and the strerrno function that will convert this to an string, > right?
Agreed, the long macro name shouldn't be visible outside of the depths of the perf files that set it and convert it to a string.
David
| |