Messages in this thread | | | Date | Mon, 28 May 2012 14:24:38 -0400 | From | Ted Ts'o <> | Subject | Re: [PATCH] FS: ext4: fix integer overflow in alloc_flex_gd() |
| |
On Mon, Feb 20, 2012 at 05:41:24PM -0500, Haogang Chen wrote: > In alloc_flex_gd(), when flexbg_size is large, kmalloc size would > overflow and flex_gd->groups would point to a buffer smaller than > expected, causing OOB accesses when it is used. > > Note that in ext4_resize_fs(), flexbg_size is calculated using > sbi->s_log_groups_per_flex, which is read from the disk and only bounded > to [1, 31]. The patch returns NULL for too large flexbg_size. > > Signed-off-by: Haogang Chen <haogangchen@gmail.com>
Thanks, applied. Apologies for missing this during the last cycle.
- Ted
| |