lkml.org 
[lkml]   [2012]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH v2 -mm 0/1] pidns: find_new_reaper() can no longer switch to init_pid_ns.child_reaper
    On 05/25, Eric W. Biederman wrote:
    >
    > Oleg Nesterov <oleg@redhat.com> writes:
    >
    > > Change find_new_reaper() to use pid_ns->parent->child_reaper.
    >
    > Oleg this is a good catch for a real problem. However I disagree about
    > the fix.
    >
    > We should make unhash_process say:
    > if ((task_active_pid_ns(parent)->child_reaper == parent) &&

    Damn, I hate you^W^W^W thanks a lot Eric.

    Indeed! Not only this is more simple, this is just more natural!

    > And we should just set delete the code after zap_pid_ns_processes

    Yes, this is clear.

    > We could set pid_ns.child_reaper to NULL after that
    > but why bother.

    Agreed. Plus I do not think that pid_ns.child_reaper == NULL looks
    good even if this doesn't matter currently.

    OK, please see v2. Note that I moved detach_pid(PIDTYPE_PID) back.
    Yes, yes, there is no real reason to do this. Just I think that if
    someone look at these changes later, it is not easy to understand
    why it was moved down.

    Thanks!

    Oleg.



    \
     
     \ /
      Last update: 2012-05-27 21:41    [W:3.803 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site