lkml.org 
[lkml]   [2012]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2] [x86]: abort secondary cpu bringup gracefully
On 05/24/2012 10:41 AM, Igor Mammedov wrote:
> ping for reviewers.
>
> Please review patch.

I can't hugely comment on the guts of what the patch is doing, but:

>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -136,6 +136,10 @@ EXPORT_PER_CPU_SYMBOL(cpu_info);
>>
>> atomic_t init_deasserted;
>>
>> +#ifdef CONFIG_HOTPLUG_CPU
>> +static void remove_siblinginfo(int cpu);
>> +#endif
>> +

#ifdefs should almost never be in C code, they should be in header
files. You can stub out functions with empty inline versions. For a
random example, see kernel/smpboot.h

Rob
--
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation. Pick one.


\
 
 \ /
  Last update: 2012-05-26 04:01    [W:1.373 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site