Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Sat, 26 May 2012 00:43:45 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 13/20] arm: Do not call try_to_freeze() in do_signal() |
| |
On Sat, May 26, 2012 at 12:04:29AM +0200, Richard Weinberger wrote: > get_signal_to_deliver() already calls try_to_freeze(), there is no > need to call it directly.
NAK. Please check linux-next (okay, viro's patches haven't appeared there yet) but a lot of this stuff is covered by a truckload of work that Al's done.
Please don't work across Al.
commit d9be5ea6f9b6a51535ccdd9881ffb3be2dbd48e9 Author: Al Viro <viro@zeniv.linux.org.uk> Date: Fri Apr 27 01:18:52 2012 -0400
arm: don't call try_to_freeze() from do_signal()
get_signal_to_deliver() will handle it itself
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c index a6c4e78..3b37c14 100644 --- a/arch/arm/kernel/signal.c +++ b/arch/arm/kernel/signal.c @@ -642,9 +642,6 @@ static void do_signal(struct pt_regs *regs, int syscall) } } - if (try_to_freeze()) - goto no_signal; - /* * Get the signal to deliver. When running under ptrace, at this * point the debugger may change all our registers ... @@ -684,7 +681,6 @@ static void do_signal(struct pt_regs *regs, int syscall) return; } - no_signal: if (syscall) { /* * Handle restarting a different system call. As above,
| ![\](/images/icornerr.gif) |