Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 00/16] vfs: atomic open v4 (part 1) | Date | Fri, 25 May 2012 16:20:03 +0100 |
| |
Miklos Szeredi <miklos@szeredi.hu> wrote:
> > Also, does it make sense to combine: > > > > if (!S_ISREG(nd->inode->i_mode)) > > will_truncate = 0; > > > > with: > > > > int will_truncate = open_flag & O_TRUNC; > > > > up at the top of the function. > > We need to check nd->inode->i_mode *after* the lookup. So top of the > function is not a good place.
Good point.
David
| |