Messages in this thread | | | Date | Tue, 22 May 2012 11:11:50 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: comedi: ii_pci20kc: iobase and ioaddr are void __iomem * |
| |
On Mon, May 21, 2012 at 06:10:07PM -0700, H Hartley Sweeten wrote: > @@ -210,7 +210,7 @@ static int pci20xxx_attach(struct comedi_device *dev, > if (ret < 0) > return ret; > > - devpriv->ioaddr = (void *)(unsigned long)it->options[0]; > + devpriv->ioaddr = (void __iomem *)(unsigned long)it->options[0];
Obviously, your patch is fine, but I was wondering if it was a problem that it->options was only a 32 bit? Seems like it would deserve a comment.
regards, dan carpenter
| |