lkml.org 
[lkml]   [2012]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86: check for valid irq_cfg pointer in smp_irq_move_cleanup_interrupt
From
Date
On Mon, 2012-05-21 at 16:09 -0500, Dimitri Sivanich wrote:
> On Mon, May 21, 2012 at 02:05:53PM -0700, Suresh Siddha wrote:
> > On Mon, 2012-05-21 at 11:49 -0500, Dimitri Sivanich wrote:
> > > The smp_irq_move_cleanup_interrupt routine should be checking for a valid
> > > irq_cfg pointer prior to accessing it. It also seems that this should be
> > > done after taking the desc lock.
> >
> > I think these changes are correct. Did you see any crashes during module
> > unload etc?
>
> Yes, we have seen these on occasion during boot.

During boot or shutdown?

Review of the code shows that this can trigger during module unload
which can call destroy_irq() etc and can trigger the crash if there is a
parallel irq migration related cleanup.

Unsuccessful module loads can also call destroy_irq() but I doubt that
is what happening here.

thanks,
suresh




\
 
 \ /
  Last update: 2012-05-21 23:41    [W:0.134 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site