Messages in this thread | | | Date | Sat, 19 May 2012 14:47:25 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 2/3] x86: x2apic/cluster: Make use of lowest priority delivery mode |
| |
On Fri, May 18, 2012 at 07:51:19PM +0400, Cyrill Gorcunov wrote: > On Fri, May 18, 2012 at 05:42:37PM +0200, Alexander Gordeev wrote: > > > Hi Alexander, > > > > > > I'm a bit confused, we do compose destination id from target cpumask > > > and send one ipi per _cluster_ with all cpus belonging to this cluster > > > OR'ed. So if my memory doesn't betray me all specified cpus in cluster > > > should obtain this message. Thus I'm wondering where do you find that > > > only one apic obtains ipi? (note i don't have the real physical > > > machine with x2apic enabled handy to test, so please share > > > the experience). > > > > This patchset is not about IPIs at all. It is about interrupts coming from > > IO-APICs. > > Ah, you mean io-apic here. I'll try to find some time tonight/tomorrow-morning > for review. Thanks!
Sorry for delay, Alexander. I can only review the code (I've no x2apic testing machine at the moment) and it looks good for me.
Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
p.s. Hope Suresh and Yinghai will take a look too. The thing which bothers me is that we use LowPrio delivery mode, while there is no lowprio in x2apic ipi messages and I assume the same should apply to ioapic generated messages.
Cyrill
| |