Messages in this thread | | | From | Vaibhav Nagarnaik <> | Date | Fri, 18 May 2012 21:57:12 -0700 | Subject | Re: [PATCH] tracing: Merge separate resize loops |
| |
On Fri, May 18, 2012 at 8:19 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > But if there were updates on a offline CPU, then the original patch > would not have set this to zero at the end.
Right.
> Or are you just saying that we don't need to set this to zero, as it > isn't used later on? And when we re-enter this function (where its the > only place, and what it calls, that uses nr_page_to_update), it gets > reset. > > IOW, this reset is just a "clean up" of the nr_pages_to_update. Right?
Yes, that's exactly right and a much better way to put it :)
It's just a reset which isn't strictly needed since nr_pages_to_update gets initialized before it is used and isn't used after resize operation.
Vaibhav Nagarnaik
| |