Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH v2 1/5] i2c: Convert i2c-octeon.c to use device tree. | Date | Sat, 19 May 2012 00:05:09 -0600 |
| |
On Thu, 26 Apr 2012 18:20:26 -0700, David Daney <ddaney.cavm@gmail.com> wrote: > From: David Daney <david.daney@cavium.com> > > There are three parts to this: > > 1) Remove the definitions of OCTEON_IRQ_TWSI and OCTEON_IRQ_TWSI2. > The interrupts are specified by the device tree and these hard > coded irq numbers block the used of the irq lines by the irq_domain > code. > > 2) Remove platform device setup code from octeon-platform.c, it is > now unused. > > 3) Convert i2c-octeon.c to use device tree. Part of this includes > using the devm_* functions instead of the raw counterparts, thus > simplifying error handling. No functionality is changed. > > Signed-off-by: David Daney <david.daney@cavium.com> > Acked-by: Rob Herring <rob.herring@calxeda.com>
Is the DT binding for this device documented?
Otherwise the code looks good. Please make sure the binding documentation is in place before merging.
g.
| |